Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Stable Functional #22

Merged
merged 9 commits into from
Jan 26, 2022
Merged

Type Stable Functional #22

merged 9 commits into from
Jan 26, 2022

Conversation

eliascarv
Copy link
Member

A small change to make the Functional type stable

@juliohm
Copy link
Member

juliohm commented Jan 26, 2022

Simple and important improvement. Awesome.

As discussed over Zulip, I like the suggestion of allowing functor objects. Feel free to update the PR accordingly and add a test for this new feature.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #22 (41638ba) into master (ce70534) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          14       14           
  Lines         346      346           
=======================================
  Hits          319      319           
  Misses         27       27           
Impacted Files Coverage Δ
src/transforms/functional.jl 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce70534...41638ba. Read the comment docs.

@eliascarv
Copy link
Member Author

This PR is ready for review @juliohm.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Just a small minor suggestion.

test/runtests.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Jan 26, 2022

Merging it 👍🏽

@juliohm juliohm merged commit 4d27537 into JuliaML:master Jan 26, 2022
@eliascarv eliascarv deleted the type-stable-functional branch January 27, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants