-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Select and Reject #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 92.19% 92.30% +0.11%
==========================================
Files 14 14
Lines 346 351 +5
==========================================
+ Hits 319 324 +5
Misses 27 27
Continue to review full report at Codecov.
|
This PR is ready for review @juliohm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome progress. Please take a look at the attached suggestions.
Also, we should make sure that the Reject transform is also working with regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Just a few more changes before we can go ahead and merge.
Great contribution 👍🏽 |
Update Select and Reject to add Regex support.
Fix #14