Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableSelection #24

Merged
merged 13 commits into from
Feb 2, 2022
Merged

TableSelection #24

merged 13 commits into from
Feb 2, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Jan 31, 2022

This PR implements a lazy type for selections/rejections.

Fix #16

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #24 (c32f319) into master (95ee4f3) will decrease coverage by 0.30%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   92.30%   92.00%   -0.31%     
==========================================
  Files          14       14              
  Lines         351      375      +24     
==========================================
+ Hits          324      345      +21     
- Misses         27       30       +3     
Impacted Files Coverage Δ
src/transforms/select.jl 93.50% <89.28%> (-2.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ee4f3...c32f319. Read the comment docs.

@juliohm juliohm marked this pull request as ready for review January 31, 2022 20:28
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
@juliohm juliohm changed the title WIP: TableSelection TableSelection Feb 1, 2022
src/transforms/select.jl Show resolved Hide resolved
src/transforms/select.jl Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
src/transforms/select.jl Outdated Show resolved Hide resolved
test/transforms.jl Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Feb 2, 2022

Another excellent PR 👍🏽

@juliohm juliohm merged commit 2cc37e8 into JuliaML:master Feb 2, 2022
@eliascarv eliascarv deleted the table-selection branch February 2, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy Select/Reject
3 participants