Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and DropMissing #28

Merged
merged 12 commits into from
Mar 30, 2022
Merged

Filter and DropMissing #28

merged 12 commits into from
Mar 30, 2022

Conversation

eliascarv
Copy link
Member

This PR add Filter and DropMissing transformations.

@eliascarv eliascarv requested a review from juliohm March 29, 2022 10:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #28 (10e53da) into master (efd8914) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   92.00%   92.48%   +0.48%     
==========================================
  Files          14       15       +1     
  Lines         375      399      +24     
==========================================
+ Hits          345      369      +24     
  Misses         30       30              
Impacted Files Coverage Δ
src/transforms.jl 97.82% <ø> (ø)
src/transforms/filter.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd8914...10e53da. Read the comment docs.

src/TableTransforms.jl Outdated Show resolved Hide resolved
src/transforms.jl Outdated Show resolved Hide resolved
src/transforms/filter.jl Outdated Show resolved Hide resolved
src/transforms/filter.jl Outdated Show resolved Hide resolved
@eliascarv eliascarv requested a review from juliohm March 29, 2022 17:28
test/runtests.jl Outdated Show resolved Hide resolved
@juliohm
Copy link
Member

juliohm commented Mar 29, 2022

As usual a great PR 👍🏽 we just need to double check the testmissing helper function, maybe we could avoid introducing a function if all we need is to check the positions of the missing values with findall.

@juliohm
Copy link
Member

juliohm commented Mar 29, 2022

Also, we need to add these two new transforms to the README table 👍🏽

@eliascarv
Copy link
Member Author

This PR is ready for a final review @juliohm!

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ready for merging. I will adjust the descriptions in the README.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@juliohm juliohm merged commit 193c0b1 into JuliaML:master Mar 30, 2022
@eliascarv eliascarv deleted the filter branch March 30, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants