-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter and DropMissing #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 92.00% 92.48% +0.48%
==========================================
Files 14 15 +1
Lines 375 399 +24
==========================================
+ Hits 345 369 +24
Misses 30 30
Continue to review full report at Codecov.
|
As usual a great PR 👍🏽 we just need to double check the testmissing helper function, maybe we could avoid introducing a function if all we need is to check the positions of the missing values with findall. |
Also, we need to add these two new transforms to the README table 👍🏽 |
This PR is ready for a final review @juliohm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are ready for merging. I will adjust the descriptions in the README.
This PR add Filter and DropMissing transformations.