Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DRS and SDS transformations. Rename files. Rewrites some code. #4

Merged
merged 17 commits into from
Oct 28, 2021
Merged

Add DRS and SDS transformations. Rename files. Rewrites some code. #4

merged 17 commits into from
Oct 28, 2021

Conversation

mrr00b00t
Copy link
Contributor

Try to add DRS and SDS transformations.

juliohm
juliohm requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs are great, you are really mastering Julia now.

mrr00b00t and others added 3 commits October 27, 2021 22:44
@mrr00b00t @juliohm
Update src/transforms/eigenanalysis.jl
2186fe7 
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@mrr00b00t @juliohm
Update src/transforms/eigenanalysis.jl
048d7ce 
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
@mrr00b00t
update means to \mu
e10c26d
@mrr00b00t
Copy link
Contributor Author

mrr00b00t commented Oct 28, 2021 •
edited
Loading

I think we could link the reference for each transformation, but I couldn't get another reference but the https://geostatisticslessons.com/lessons/sphereingmaf for DRS and SDS transforms.

@juliohm
Copy link
Member

juliohm commented Oct 28, 2021

If we can't find other references, then this link is fine too.

juliohm
juliohm requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new docstring is great. Can you please confirm that you are not copying the text? We need to be careful with plagiarism on the internet. If you wrote with your own words, that is safe.

We should probably add a link to the website.

@juliohm juliohm merged commit f702597 into master Oct 28, 2021
@juliohm juliohm deleted the add-drs-sds-transform branch October 28, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliohm juliohm juliohm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrr00b00t @juliohm