Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #298

Merged
merged 1 commit into from Oct 1, 2023
Merged

Fix typos #298

merged 1 commit into from Oct 1, 2023

Conversation

DanielVandH
Copy link
Contributor

@DanielVandH
Copy link
Contributor Author

This could probably just as well be applied to docstrings, but I didn't include .jl files in the tool.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #298 (1d80fcd) into master (0865eb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          77       77           
  Lines        7084     7084           
=======================================
  Hits         7066     7066           
  Misses         18       18           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer
Copy link
Member

Thanks for running this. If you like, sure also apply it to the doc strings. I will check carefully that we do not have a false-positive in there later, though :)

@DanielVandH
Copy link
Contributor Author

Turns out that I don't know how to get it to properly work for .jl files, so I will leave it there (:.

Note that the initial check from this tool is all automatic, but I have to manually confirm one-by-one (there are many false positives initially!) so I think there shouldn't be any issues hopefully.

@kellertuer
Copy link
Member

Thanks again, I checked the typos and there are no false-positives.
If you find the time to twiddle with the check to also include the docs, that would be neat. For this PR, we can just merge this and it is then part of the next release :)

Thanks again!

@kellertuer kellertuer merged commit ba8d5cf into JuliaManifolds:master Oct 1, 2023
13 checks passed
@DanielVandH DanielVandH deleted the fix-typos branch October 1, 2023 14:46
@DanielVandH DanielVandH mentioned this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants