Change PSO SC to a more efficient way of computing. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 73 73
Lines 6819 6839 +20
=======================================
+ Hits 6801 6821 +20
Misses 18 18 ☔ View full report in Codecov by Sentry. |
kellertuer
added
the
Ready-for-Review
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
|
Will merge this but only register it together with #370 once that is also merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought a bit about #347. The velocities are actually equivalent to the change (the same if the steps are computed with exp). So this PR changes the stopping criterion of SC to this – a bit nicer – form.
Still to check