Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StopWhenAny constructor for Vector #376

Merged
merged 5 commits into from
Apr 7, 2024

Conversation

Vaibhavdixit02
Copy link
Contributor

The element type should be subtype of StoppingCriterion

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (7f8d7c6) to head (1b211bf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   99.74%   99.76%   +0.01%     
==========================================
  Files          74       74              
  Lines        7167     7167              
==========================================
+ Hits         7149     7150       +1     
+ Misses         18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member

Ah, well-spotted; it even seems we usually always used the constructor in the line after that.

Could you

  • add a small test for this case
  • add a small entry in the changelog (cf. the other PR currently open for example) so this is reflected in there?

Thanks for opening this :)

@mateuszbaran mateuszbaran mentioned this pull request Apr 6, 2024
4 tasks
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick adaptions and fixing that bug :)

@kellertuer kellertuer merged commit dbb2943 into JuliaManifolds:master Apr 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants