-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support of subsolver records. #377
Conversation
…me `RecordSubsolverRecordings` to `RecordSubsolver` and use `:Subsolver` there instead (in recordings, not debug).
…cordEvery not yet.
The design is nice and seems to work in general. I went for The main thing that seems to bother a bit still is, that though there is a lot of resets implemented, it seems that the recording of subsolver recordings is still incremental, this needs to be fixed still. |
Got it to work, even with a small add-on such that with the keywords
The subsolver records its stopping reason at the end, and the “Subsolver recorder” takes over everything recorded at the stop. (by default that second element is One can of course also do So with that this is feature complete (but not yet doc / test complete). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 74 74
Lines 7167 7241 +74
=======================================
+ Hits 7150 7224 +74
Misses 17 17 ☔ View full report in Codecov by Sentry. |
… ideas for today.
…ds/Manopt.jl into kellertuer/subsolver-record # Conflicts: # src/plans/record.jl
26849c5
to
8fc929c
Compare
This is a PR to resolve #371.
:Stop
RecordStoppingReason
action to record the stopping reason (dah!)RecordWhenActive
(analogue to debug), though not 100% necessary, might be nice to reduce allocations when only requiring everyRecordSubsolverRecords
action that stores the sub solvers record (or parts of it) in the parents record entry for that iterationToDo
Open Points
Currently the symbol
:Subsolver
is used in subsolvers to declare them beding dependent (of the parent), while it might be breaking:WhenActive
might be a nicer symbol. The:Subsolver
could be used to indicate subsolver recordings. I have to think about this a bit and whether this is seriously breaking, since for now:Subsolver
. On the other hand it is not breaking code to the extend it does now work, just that since the last release to this then some might get a bit more subsolver debug.