Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate extension of Base.gradient #80

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Conversation

mlubin
Copy link
Collaborator

@mlubin mlubin commented Nov 1, 2015

This export is a common source of confusion for users of ForwardDiff, e.g. JuliaDiff/ForwardDiff.jl#70. I don't think Calculus has a claim to extend Base's method any more so than ForwardDiff, so the least confusing solution is for neither to extend the method.

CC @jrevels

@mlubin
Copy link
Collaborator Author

mlubin commented Nov 1, 2015

CC @scidom

@papamarkou
Copy link

Good point, I agree; it may be better not to let Calculus extend the method as scope issues can be easily missed otherwise.

johnmyleswhite added a commit that referenced this pull request Nov 3, 2015
deprecate extension of Base.gradient
@johnmyleswhite johnmyleswhite merged commit cb42f36 into master Nov 3, 2015
@mlubin mlubin deleted the ml/gradient branch November 5, 2015 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants