Add special case comparisons of Decimal with NaN/Inf #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inf
is a common starting value formin
comparisons (and similarlyfor
-Inf
and max). As an example Plots.jl uses it to figure outthe extrema of values to be plotted. Since Inf is not representable
in Decimal, these comparisons were throwing an error. Fix this by
adding special case comparisons with AbstractFloat that behave properly
for the Inf case.