Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less than or equal to for Decimals #47

Merged
merged 3 commits into from Jan 27, 2020

Conversation

nicoleepp
Copy link
Contributor

Closes #46

@coveralls
Copy link

coveralls commented Jan 24, 2020

Pull Request Test Coverage Report for Build 118

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 96.262%

Totals Coverage Status
Change from base Build 116: 1.2%
Covered Lines: 103
Relevant Lines: 107

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #47 into master will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   95.28%   96.29%   +1.01%     
==========================================
  Files           6        6              
  Lines         106      108       +2     
==========================================
+ Hits          101      104       +3     
+ Misses          5        4       -1
Impacted Files Coverage Δ
src/Decimals.jl 100% <ø> (ø) ⬆️
src/equals.jl 100% <100%> (ø) ⬆️
src/arithmetic.jl 81.25% <0%> (+1.25%) ⬆️
src/decimal.jl 100% <0%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64d38e...e87f8a2. Read the comment docs.

@nicoleepp nicoleepp requested a review from hurak January 24, 2020 16:27
@mattBrzezinski
Copy link

I don't understand why >= is working, but I feel like be explicit about it here would be beneficial.

src/equals.jl Outdated Show resolved Hide resolved
@fchorney
Copy link

fchorney commented Jan 24, 2020

I don't understand why >= is working, but I feel like be explicit about it here would be beneficial.

in julia x >= y is defined as y <= x so you only need to define the one
>=(x, y) = (y <= x)

@ararslan ararslan merged commit 234d3ee into JuliaMath:master Jan 27, 2020
@nicoleepp nicoleepp deleted the ne/lessthanorequalto branch January 27, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<= not defined for Decimal
7 participants