Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector_view should be a type (probably a subtype of AbstractArray) #11

Closed
stevengj opened this issue Apr 4, 2013 · 1 comment
Closed

Comments

@stevengj
Copy link
Member

stevengj commented Apr 4, 2013

The GSL vector_view type is pretty much totally redundant with the Julia SubArray type, so I would tend to not include it at all (issue #12).

However, if you are going to include it, you must define it as a type which contains a reference to the original Array that was used to construct it, as otherwise the latter may be garbage-collected by Julia, which would lead to a crash when GSL next tries to access the vector contents.

@jiahao
Copy link
Collaborator

jiahao commented Apr 4, 2013

Agreed, nix vector_view

@jiahao jiahao closed this as completed Apr 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants