Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't wrap GSL functionality that is redundant with the Julia standard library #12

Closed
stevengj opened this issue Apr 4, 2013 · 2 comments

Comments

@stevengj
Copy link
Member

stevengj commented Apr 4, 2013

There are some portions of GSL that are so redundant with the Julia standard library that it is almost inconceivable that anyone would want to use them.

The whole GSL vector and matrix interface, the BLAS interface, the linear algebra and eigensystems interfaces, the FFT functions, and the basic complex-number routines are vastly inferior to those bundled with Julia, for example, and I would tend to just omit them from GSL.jl.

Including them increases your maintenance load, requires special care to avoid crashing interactions with the garbage collection (issue #11), and slows down the loading of the GSL package (using GSL is pretty slow as it is, so anything to trim the library would be an improvement).

@jiahao
Copy link
Collaborator

jiahao commented Apr 4, 2013

I agree with removing everything that is redundant with Julia's existing functionality. The BLAS interface was the one thing I noticed right away, and I simply hadn't taken the time to list and excise the various redundant classes of things. I'll certainly remove the ones listed above right away to begin with.

jiahao added a commit that referenced this issue Apr 4, 2013
Removes gsl_eigen_*, gsl_complex_*, gsl_sort_*, gsl_vector_*, gsl_matrix_*, blas*, cblas*, gsl_fft*, gsl_linalg* functions, which are redundant with native Julia functionality. Addresses #12
jiahao added a commit that referenced this issue Apr 4, 2013
Removes gsl_eigen_*, gsl_complex_*, gsl_sort_*, gsl_vector_*, gsl_matrix_*, blas*, cblas*, gsl_fft*, gsl_linalg* functions, which are redundant with native Julia functionality. Addresses #12
@jiahao
Copy link
Collaborator

jiahao commented Apr 4, 2013

I've explicitly removed gsl_eigen__, gsl_complex__, gsl_sort__, gsl_vector__, gsl_matrix__, blas_, cblas_, gsl_fft_, gsl_linalg* wrappers. Do let me know if I've missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants