Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lanczos Resampling #366

Closed
mileslucas opened this issue Apr 19, 2020 · 2 comments · Fixed by #369
Closed

Lanczos Resampling #366

mileslucas opened this issue Apr 19, 2020 · 2 comments · Fixed by #369

Comments

@mileslucas
Copy link
Contributor

I'm interested in implementing a Lanczos resampling algorithm here. This appears to be simply the convolution of the Lanczos Kernel by the samples.

I created a fork and started developing, but I have become completely overwhelmed by the complexity inside the library. I have no idea if such an interpolator should be its own interpolation type, or if it should be a Gridded type. I also have no clue how to interface with, well, anything here.

Can i get some advice on how/where to implement this algorithm (and whether you want it at all!)?

@MatFi
Copy link
Contributor

MatFi commented Apr 20, 2020

First of all I don't now much about the internals, but after consulting the DevDocs (part of #365) I think that it's not easy to do this with the Gridded directly, because it somehow built to work with polynomials rather then with convolutions.
In terms of implementation it's probably a use case for FFT, at least when the window gets large (which is difficult in case of non-equidistant data). And actually it would be good to have some ConvolutionInterpolation, where you can define arbitrary window functions. But again, I'am not an expert regarding this package (which is looking for a new maintainer #365)

@mkitti
Copy link
Collaborator

mkitti commented May 7, 2020

I am definitely interested in adding FFT based interpolation schemes to this library. I'm getting up to speed on the library itself. I will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants