Simplify indexing #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to JuliaLang/julia#10525 we no longer need these :)
|
It was more likely there to avoid an ambiguity warning. Should not be necessary anymore, I assume. 👍 |
|
There's still some work to do here, though, as noted in JuliaLang/julia#12273 (comment). Now that I know that you (probably) don't need the method for something specific, I can just remove it if I find that there's another with cartesian indexes provdided by base :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some code that's no longer needed, thanks to JuliaLang/julia#10525. Hopefully, this will make it a little easier to extend the package in the future.
@timholy I assume that the method taking a
CartesianIndexis an optimization. Is this somehow also provided by base Julia now?