-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cumsum_kbn signature is too restrictive #4
Comments
It also seems to assume 1-based indexing. Generalizing that to allow |
OK -- revisiting.
|
JeffreySarnoff
added a commit
that referenced
this issue
Jun 7, 2022
fixed in master |
JeffreySarnoff
added a commit
that referenced
this issue
Jun 7, 2022
Update Project.toml test Julia v"1.6" and nightly generalize signatures Update KahanSummation.jl cleanup type param conflict with var change Vector to Array modernize kwarg use provide generalized sigs better coverage Update Project.toml make generalized more specific to avoid recalling same function fix Generator spelling fix copypaste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The signature
cumsum_kbn(v::AbstractVector{T}) where T<:AbstractFloat
seems too restrictive. What about summingComplex{Float64}
orSVector{Float64,3}
, for example?sum_kbn
accepts any type, which seems more reasonable. (If you pass something like an array of integers, it will still work, just wasting some computations.)The text was updated successfully, but these errors were encountered: