Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the dimension argument to cumsum_kbn a keyword argument #12

Merged
merged 1 commit into from Jan 4, 2021
Merged

Make the dimension argument to cumsum_kbn a keyword argument #12

merged 1 commit into from Jan 4, 2021
+9 −7

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan requested a review from stevengj August 27, 2018 20:13
@ararslan
Copy link
Member Author

ararslan commented Jan 4, 2021

Seems like we should probably make this change. @stevengj, thoughts?

@stevengj
Copy link
Member

stevengj commented Jan 4, 2021

LGTM.

@ararslan ararslan merged commit d019625 into master Jan 4, 2021
@ararslan ararslan deleted the aa/kwarg branch January 4, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj Awaiting requested review from stevengj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ararslan @stevengj