WIP: leverage Base reduction functions #7
Conversation
src/KahanSummation.jl
Outdated
| import Base.TwicePrecision | ||
|
|
||
|
|
||
| function plus_kbn(x::T, y::T) where {T} |
There was a problem hiding this comment.
Should these be restricted to T<:Real? Also do they necessarily have to be the same type? Using + as we do here should take care of any promotion that needs to happen.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This is a lot of blank lines. Could you reduce it to just one, maybe two?
There was a problem hiding this comment.
No. I need those for caching 
|
This looks really cool! Is there any noticeable change in performance? |
|
AHHHHH!!!!! This doesn't work on 0.7 because |
Since the demise of `r_promote` in #22825, there is now a type-instability in `mapreduce` if the operator does not give an element of the same type as the input. This arose during my implementation of Kahan summation using a reduction operator, see: JuliaMath/KahanSummation.jl#7 This adds a `mapreduce_single` function which defines what the result should be in these cases.
Since the demise of `r_promote` in #22825, there is now a type-instability in `mapreduce` if the operator does not give an element of the same type as the input. This arose during my implementation of Kahan summation using a reduction operator, see: JuliaMath/KahanSummation.jl#7 This adds a `mapreduce_single` function which defines what the result should be in these cases.
Since the demise of `r_promote` in #22825, there is now a type-instability in `mapreduce` if the operator does not give an element of the same type as the input. This arose during my implementation of Kahan summation using a reduction operator, see: JuliaMath/KahanSummation.jl#7 This adds a `mapreduce_single` function which defines what the result should be in these cases.
Since the demise of `r_promote` in #22825, there is now a type-instability in `mapreduce` if the operator does not give an element of the same type as the input. This arose during my implementation of Kahan summation using a reduction operator, see: JuliaMath/KahanSummation.jl#7 This adds a `mapreduce_single` function which defines what the result should be in these cases.
|
Would it be possible to re-activate/implement that pull request? |
|
We do not care about support for Julia 0.7. If you can get this work as intended for Julia "1.6+", we are open to including it. |
This is something I have been meaning to do for a while. Basically the idea is to define a kbn addition operator, and define all the reductions in terms of that.