Skip to content

Commit

Permalink
close issue #566 (#567)
Browse files Browse the repository at this point in the history 
* close issue #566

* remove bad test

* typo
  • Loading branch information
@jverzani
jverzani committed Apr 26, 2024
1 parent 5d4b35f commit 263b965
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Expand Up @@ -2,7 +2,7 @@ name = "Polynomials"
uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
license = "MIT"
author = "JuliaMath"
version = "4.0.7"
version = "4.0.8"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
3 changes: 2 additions & 1 deletion src/rational-functions/common.jl
View file
Expand Up @@ -69,7 +69,8 @@ function Base.convert(::Type{PQ}, p::P) where {PQ <: AbstractRationalFunction, P
T = isnothing(T′) ? eltype(p) : T′
X = indeterminate(PQ, p)

𝐩 = convert(Polynomial{T,X}, p)
𝑃 = Polynomials.:⟒(p)
𝐩 = convert(𝑃{T,X}, p)
rational_function(PQ, 𝐩, one(𝐩))
end

Expand Down
5 changes: 4 additions & 1 deletion test/rational-functions.jl
View file
Expand Up @@ -118,7 +118,10 @@ end

## T, Polynomial{T} promotes
@test eltype([1, p, pp]) == PP
@test eltype(eltype(eltype([im, p, pp]))) == Complex{Int}
promote(im, p); promote(p, pp) # but promote(im, pp) fails
## this is a bad test, a,b =promote(im,p) leave a P{Complex}
## which doesn't convert to type pp.
# @test eltype(eltype(eltype([im, p, pp]))) == Complex{Int}

## test mixed types promote polynomial type
@test eltype([pp rr p r]) == PP
Expand Down

5 comments on commit 263b965

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegister register

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giordano I feel like I lost some permissions on JuliaMath that allowed me to register this package. If that is correct, could you set me up? Many thanks. (I hope you have this ability ;)

@giordano
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again? Maybe the bit is just down

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/105745

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v4.0.8 -m "<description of version>" 263b965ba2b5c6cec7b48aa4d760658707fba1c4
git push origin v4.0.8

Please sign in to comment.