Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 566a #570

Merged
merged 2 commits into from May 10, 2024
Merged

Issue 566a #570

merged 2 commits into from May 10, 2024

Conversation

jverzani
Copy link
Member

Address last example given in #566.

  • better handles rational function of Laurent polynomials
  • needed to make promote_rule promote to Laurent type, not Polynomial type.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.69%. Comparing base (263b965) to head (55a58f8).

Files Patch % Lines
src/rational-functions/rational-function.jl 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   75.79%   75.69%   -0.10%     
==========================================
  Files          38       38              
  Lines        4032     4037       +5     
==========================================
  Hits         3056     3056              
- Misses        976      981       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani jverzani merged commit 87f02db into JuliaMath:master May 10, 2024
19 of 22 checks passed
@jverzani jverzani deleted the issue_566a branch May 10, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant