Skip to content

Commit

Permalink
close issue #162 (#163)
Browse files Browse the repository at this point in the history 
* close issue #162

* version bump
  • Loading branch information
@jverzani
jverzani committed Aug 17, 2019
1 parent 95a79ef commit 2921a2d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Roots"
uuid = "f2b01f46-fcfa-551c-844a-d8ac1e96c665"
version = "0.8.2"
version = "0.8.3"

[deps]
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
Expand Down
5 changes: 2 additions & 3 deletions src/bracketing.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,11 @@ function find_zero(fs, x0, method::M;
options = init_options(method, state; kwargs...)

# check if tolerances are exactly 0
tol = max(options.xabstol, options.xreltol)
ftol = max(options.abstol, options.reltol)
iszero_tol = iszero(options.xabstol) && iszero(options.xreltol) && iszero(options.abstol) && iszero(options.reltol)

l = (verbose && isa(tracks, NullTracks)) ? Tracks(eltype(state.xn1)[], eltype(state.fxn1)[]) : tracks

if iszero(tol) && iszero(ftol)
if iszero_tol
if T <: FloatNN
return find_zero(F, x, BisectionExact(); tracks=l, verbose=verbose, kwargs...)
else
Expand Down

4 comments on commit 2921a2d

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Register Failed
@jverzani, it looks like you are not a publicly listed member/owner in the parent organization (JuliaMath).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/2753

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.3 -m "<description of version>" 2921a2dba2023de3f25681383009b24cde3370b2
git push origin v0.8.3

Also, note the warning: Version 0.8.3 skips over 0.8.2
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

Please sign in to comment.