Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muller inefficient #221

Closed
jacobwilliams opened this issue Jul 17, 2021 · 2 comments · Fixed by #222
Closed

muller inefficient #221

jacobwilliams opened this issue Jul 17, 2021 · 2 comments · Fixed by #222

Comments

@jacobwilliams
Copy link
Contributor

The muller function is very inefficient since it's recomputing all three function evaluations every iteration, even though two of them have already been computed in the previous iteration.
jacobwilliams added a commit to jacobwilliams/Roots.jl that referenced this issue Jul 17, 2021
@jacobwilliams
eliminated unnecessary function evals in muller
d6136f8 
Fixes JuliaMath#221
@jacobwilliams jacobwilliams mentioned this issue Jul 17, 2021
Merged
@jacobwilliams
Copy link
Contributor Author

Just sent a PR for this. I haven't looked at any of the other methods to see if they have the same problem.

@jverzani
Copy link
Member

Thanks for this! I'll merge in and bump the version number once the tests run.

jverzani pushed a commit that referenced this issue Jul 18, 2021
@jacobwilliams
eliminated unnecessary function evals in muller (#222)
d88e0b0 
Fixes #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eliminated unnecessary function evals in muller jacobwilliams/Roots.jl
2 participants
@jverzani @jacobwilliams