-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump major version for breaking changes #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch to accumulate breaking changes
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 84.74% 84.76% +0.02%
==========================================
Files 34 32 -2
Lines 2097 2054 -43
==========================================
- Hits 1777 1741 -36
+ Misses 320 313 -7
Continue to review full report at Codecov.
|
* update bisection: remove BisectionExact, Accelerated; rework assess_convergence, ... * clean up alefeld potra shi; tolerances for FalsePosition(12) * tidy up AlefeldPotraShi code * clean up bracketing methods
* change to iterator, could deprecate * more consistent naming * remove deprecated run_bisection * change default solves for `solve(::ZeroProblem)`, update documentation * remove maxfnevals from tolerances which is no longer used
* clean up convergence * remove BisectionExact
* check for exact zero * check f==0 and f~ 0 separately
* use unicode subscripts when displaying trace * clean up tracks, add generics, improve docs
* add test for v1.6; allow v1.0.X to fail * testing fix
* add test for v1.6; allow v1.0.X to fail * testing fix * avoid inferred for < v1.6.0
* add test for v1.6; allow v1.0.X to fail * testing fix * avoid inferred for < v1.6.0 * uggh
* maxevals -> maxiters; allow old use * add nan(T) method * copy edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to accumulate breaking changes
remove deprecations
Bisection over non-FloatNN uses non-zero tolerances and bisection, not hacky A42 behind the scenes. Default over FloatNN uses zero tolerances and special code path for performance.
adjust tolerances for bracketing methods, tweak convergence criteria to be more standard, less idiosyncratic
drop some of the type hierarchy for bracketing (the Accelerated.., BisectionExact)
regularize naming of abstract methods, e.g. AbstractBracketing -> AbstractBracketingMethod (no means to deprecate this?);
make separate code path to solve default bisection over FloatNN (~ 10% faster)
emphasize use of keyword (not positional argument) to pass parameter
Create diversity in options type for dispatch remove unused
maxfnevals
from options;Instead of
assess_convergence
depending on the method, include method calls within to depend on method and options typesclean up docstrings abit
adjust output of Tracks object a bit; keep track of "x,fx" and "a, b" so that hybrid methods can be tracked better; add some API to Tracks objects for users: empty!, last, get
break up
order0.jl
intohybrid.jl
(fixing logging bug) andorder0
use
maxiters
notmaxevals
, as it is more common throughout ecosystem, but still allowingmaxevals
. (Similar toatol
is preferred, butabstol
allowsed.)