Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alefeld shi refreshl close #359 #363

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Apr 16, 2023

  • reorganizes alefeld, potra, shi code, hewing more closely to the paper
  • The reorganization has some performance penalty; if this is noticeable the original can be returned as a special case.
  • closes issue Bracketed Halley? #359, though maybe not with the most performant solution

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage: 95.33% and project coverage change: +0.90 🎉

Comparison is base (9deede6) 85.29% compared to head (86d27e2) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   85.29%   86.19%   +0.90%     
==========================================
  Files          35       35              
  Lines        2135     2159      +24     
==========================================
+ Hits         1821     1861      +40     
+ Misses        314      298      -16     
Impacted Files Coverage Δ
src/find_zero.jl 95.83% <ø> (ø)
src/trace.jl 28.57% <ø> (ø)
src/Bracketing/alefeld_potra_shi.jl 95.02% <94.82%> (+9.31%) ⬆️
src/Bracketing/bracketing.jl 97.05% <100.00%> (ø)
src/Derivative/halley_like.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jverzani jverzani merged commit 90b8766 into JuliaMath:master Apr 17, 2023
13 of 16 checks passed
@jverzani jverzani deleted the alefeld_shi_refresh branch April 17, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant