Skip to content

Commit

Permalink
Fix #57
Browse files Browse the repository at this point in the history
  • Loading branch information
Viral B. Shah committed Mar 3, 2016
1 parent 3851036 commit f3d5009
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ powerPC.
Linux and Windows.
3. Use `make USECLANG=1` to build with clang. This is the default on OS X
and FreeBSD.
4. Use `make ARCH=i386` to build for i386. Other supported architectures are
i486, i586, i686, x86_64, and various arm architectures.
4. Architectures are auto-detected. Use `make ARCH=i386` to force a
build for i386. Other supported architectures are i486, i586, and
i686. GCC 4.8 is the minimum requirement for correct codegen on
older 32-bit architectures.
5. On OpenBSD, you need to install GNU Make (port name: `gmake`) and a recent
version of `gcc` (tested: 4.9.2), as the default version provided by OpenBSD
is too old (4.2.1). If you use OpenBSD's port system for this (port name:
Expand Down

3 comments on commit f3d5009

@tkelman
Copy link
Contributor

@tkelman tkelman commented on f3d5009 Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this short of a commit message doesn't meet what we would ask for of a new contributor in a PR

@StefanKarpinski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We should not be writing commit messages that are just "fix #n".

@ViralBShah
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally get lazier on openlibm, but I guess it is in wider use now.

Please sign in to comment.