Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetBSD fix #197

Closed
wants to merge 2 commits into from
Closed

NetBSD fix #197

wants to merge 2 commits into from

Conversation

gufe44
Copy link
Contributor

@gufe44 gufe44 commented Oct 25, 2019 •
edited

@ViralBShah
Copy link
Member

@Keno ?

@staticfloat
Copy link
Contributor

LGTM

vtjnash
vtjnash requested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we call this openlibm_weak_reference (and change __strong_reference and __warn_reference at the same time to keep things consistent)

src/cdefs-compat.h Outdated Show resolved Hide resolved
@gufe44 @vtjnash
Update src/cdefs-compat.h
ea065f9 
Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
@Keno
Copy link
Contributor

Keno commented Oct 25, 2019

Do any of our CI services have NetBSD support? Would be nice to get a CI runner to avoid regressions.

@ararslan
Copy link
Member

Do any of our CI services have NetBSD support?

Nope. It might be possible on the paid tier of Cirrus (which allows you to use arbitrary GCP images) but otherwise I don't think so.

@gufe44
Copy link
Contributor Author

gufe44 commented Oct 25, 2019

Sorry, what I commited is not right at all... is cdefs-compat.h moving in the right direction at least?

@gufe44
Copy link
Contributor Author

gufe44 commented Oct 26, 2019

Please excuse my "experimental" use of this platform. I really didn't mean to abuse the PR in this way. I am not suggesting master...gufe44:netbsd-fix-openlibm_weak_reference as a solution but it should now somewhat conform to #197 (review). Can you verify this is really what you want?

@vtjnash
Copy link
Contributor

vtjnash commented Oct 26, 2019

Looks right to me

@ViralBShah
Copy link
Member

ViralBShah commented Oct 26, 2019 •
edited

I made the new PR in #198 out of that branch.

@ViralBShah ViralBShah mentioned this pull request Oct 26, 2019
Merged
@ViralBShah ViralBShah closed this Oct 26, 2019
@gufe44 gufe44 deleted the netbsd-fix branch August 14, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash requested changes

@staticfloat staticfloat Awaiting requested review from staticfloat

@ViralBShah ViralBShah Awaiting requested review from ViralBShah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gufe44 @ViralBShah @staticfloat @Keno @ararslan @vtjnash