Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QuasiDiagonal #61

Merged
merged 3 commits into from
May 4, 2021
Merged

Support QuasiDiagonal #61

merged 3 commits into from
May 4, 2021

Conversation

dlfivefifty
Copy link
Member

@dlfivefifty dlfivefifty commented Mar 24, 2021

@jagot this would avoid the deprecation warning though I'm inclined to not merge this until the next breaking change tag

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #61 (1b57646) into master (ce37dcd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1b57646 differs from pull request most recent head 0bf4d2f. Consider uploading reports for the commit 0bf4d2f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   84.06%   84.07%   +0.01%     
==========================================
  Files          10       10              
  Lines        1406     1407       +1     
==========================================
+ Hits         1182     1183       +1     
  Misses        224      224              
Impacted Files Coverage Δ
src/diagonal.jl 84.31% <100.00%> (ø)
src/memorylayout.jl 82.46% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce37dcd...0bf4d2f. Read the comment docs.

@jagot
Copy link

jagot commented Mar 24, 2021

I don't need it soon, so merging this can wait.

@dlfivefifty dlfivefifty merged commit 219e0af into master May 4, 2021
@dlfivefifty dlfivefifty deleted the dl/quasidiag branch May 4, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants