Make AtomView rely on struct-of-array format #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Here is a proposal to simplify a little bit the definition of struct-of-array systems, like
FastSystem
.Currently, the two following definitions are required for each property like
position
:Since they are quite redundant, I suggest not requiring the latter. Instead, a
position(system, i)
call would be intercepted by the already existing fallbackAtomsBase.jl/src/interface.jl
Line 100 in 0927561
which can be made to work simply by tweaking the definitions of
position(v::AtomView)
. The emitted code should be identical in the end.Also add some documentation for
AtomView
(since it is already exported and mentioned in the docs).