Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of expensive tests and test case for running the examples once. #116

Merged
merged 7 commits into from Feb 2, 2020

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Jan 28, 2020

Expensive tests and example tests are now integrated into the main test suite. By default the Travis-CI runs neither expensive / example, whereas tests on a "normal" computer run expensive tests, but not the examples.

To run only the non-expensive (fast) tests, issue

Pkg.test("DFTK"; test_args = ["fast"])

To only run the example tests, issue

Pkg.test("DFTK"; test_args = ["examples"])

Closes #70.

test/runexamples.jl Outdated Show resolved Hide resolved
@antoine-levitt
Copy link
Member

Hm, I don't like the fact that the examples are not on CI. Can't we just trim them down a bit so it's feasible to run them there? It also makes it simpler to run and see quickly what's going on. Then we comment that if the user wants more realistic results they have to increase the cutoffs.

@mfherbst
Copy link
Member Author

mfherbst commented Jan 29, 2020

Who says they won't be on CI? Be a bit patient with me ;)

@antoine-levitt
Copy link
Member

Ah, I didn't see the draft tag!

@mfherbst mfherbst force-pushed the selective_tests branch 5 times, most recently from 913bfa9 to 7a39658 Compare January 29, 2020 19:31
@mfherbst mfherbst marked this pull request as ready for review January 29, 2020 19:56
@mfherbst
Copy link
Member Author

@antoine-levitt Let me know what you think ... The examples do not yet pass, but I'm working on that.

@mfherbst mfherbst force-pushed the selective_tests branch 4 times, most recently from 8e93857 to 234699f Compare January 31, 2020 22:57
test/runtests.jl Outdated Show resolved Hide resolved
test/silicon_lda.jl Outdated Show resolved Hide resolved
test/silicon_runners.jl Outdated Show resolved Hide resolved
@mfherbst mfherbst force-pushed the selective_tests branch 2 times, most recently from 3833c94 to 3ad1172 Compare February 2, 2020 12:03
@mfherbst mfherbst merged commit eeaf145 into master Feb 2, 2020
@mfherbst mfherbst deleted the selective_tests branch February 2, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test examples and expensive tests
2 participants