Add a preference option for DFTK threading #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfherbst
reviewed
May 16, 2024
Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2. - [Release notes](https://github.com/julia-actions/cache/releases) - [Commits](julia-actions/cache@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Open
|
This works fine locally, so let's merge? |
|
Does this allow to enable and disable it without launching again DFTK? For some computations, it makes sense to have multiple/single thread DFTK in the same script. |
epolack
reviewed
May 23, 2024
|
Nope, I figured let's do the simple thing and require a reboot... |
epolack
reviewed
May 23, 2024
|
Thanks! @mfherbst OK to merge? |
mfherbst
reviewed
May 24, 2024
src/common/threading.jl
Outdated
| FFTW.set_num_threads(n_fft) | ||
| BLAS.set_num_threads(n_blas) | ||
| mpi_master() && @info "Threading setup:" n_fft n_blas n_julia | ||
| mpi_master() && @info "Threading setup: $(Threads.nthreads()) Julia threads, $n_DFTK DFTK threads, $n_fft FFT threads, $n_blas BLAS threads" |
There was a problem hiding this comment.
Why? The other option gave a nice table?
Also line too long :-P
There was a problem hiding this comment.
Ah I didn't know this, pretty nice
|
Review done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because untested so there's probably typos, I'll put it through its paces sometime later, but should be complete.