Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Julia 0.7 #127

Merged
merged 8 commits into from Jul 16, 2018
Merged

Require Julia 0.7 #127

merged 8 commits into from Jul 16, 2018

Conversation

anriseth
Copy link
Collaborator

I just want to see what femtocleaner has to say here (Ref #126 )

@codecov
Copy link

codecov bot commented Jul 15, 2018

Codecov Report

Merging #127 into master will increase coverage by 1.46%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   65.03%   66.49%   +1.46%     
==========================================
  Files           8        8              
  Lines         652      388     -264     
==========================================
- Hits          424      258     -166     
+ Misses        228      130      -98
Impacted Files Coverage Δ
src/strongwolfe.jl 73.52% <ø> (-0.48%) ⬇️
src/hagerzhang.jl 48.88% <0%> (-13.4%) ⬇️
src/backtracking.jl 86.2% <100%> (+4.15%) ⬆️
src/static.jl 87.5% <100%> (+55.14%) ⬆️
src/LineSearches.jl 100% <100%> (+10.71%) ⬆️
src/initialguess.jl 87.01% <50%> (-1.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc27e6e...a3f3599. Read the comment docs.

@anriseth
Copy link
Collaborator Author

There were lots of deprecation warnings from HigherPrecision because T(0) no longer defaults to convert(T, 0).
I have therefore changed all lines calling T(<number>) to convert(T, <number>). It does not look as nice, but the alternative would have to be to rely on all number types defining T(x::Number) = convert(T, x) ...

@anriseth anriseth merged commit c6747d4 into master Jul 16, 2018
@anriseth anriseth deleted the femto branch July 16, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant