Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for disabling warnings #1058

Merged
merged 1 commit into from Dec 12, 2023

Conversation

MilesCranmer
Copy link
Contributor

This my second attempt at #1049. This time I add a new option for configuring this.

@mohamed82008 @pkofod could you please prioritize reviewing and merging one of these? For the past 3 months this has been blocking us from upgrading our ecosystem of symbolic regression tools to the latest version of Optim.jl.

I have kept #1049 open FYI. I'm happy with either one, I just need a way to turn the warnings off, lest PySR's output be overrun with unnecessary warnings.

@MilesCranmer
Copy link
Contributor Author

Ping @mohamed82008 @pkofod. Sorry for being annoying but I've been waiting for this since August and it is still blocking me from upgrading.

@pkofod
Copy link
Member

pkofod commented Dec 11, 2023

Ping @mohamed82008 @pkofod. Sorry for being annoying but I've been waiting for this since August and it is still blocking me from upgrading.

not annoying. Your ping to Mohamed managed to make its way through him to me :) I'll look. Thanks

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fa5d61) 85.29% compared to head (5232f22) 84.94%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   85.29%   84.94%   -0.35%     
==========================================
  Files          43       44       +1     
  Lines        3216     3427     +211     
==========================================
+ Hits         2743     2911     +168     
- Misses        473      516      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkofod pkofod merged commit 2970e1b into JuliaNLSolvers:master Dec 12, 2023
7 of 8 checks passed
@MilesCranmer
Copy link
Contributor Author

Thanks again for merging this @pkofod!

I was wondering if you or @mohamed82008 might be able to trigger a release so I can update my dependencies?

@pkofod
Copy link
Member

pkofod commented Jan 23, 2024

I'll tag a new release, yes

@MilesCranmer MilesCranmer deleted the disable-warnings-try-2 branch January 23, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants