Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompilation issue #1088

Merged
merged 1 commit into from Apr 2, 2024
Merged

Fix precompilation issue #1088

merged 1 commit into from Apr 2, 2024

Conversation

devmotion
Copy link
Contributor

Fixes #1087 (basically in the same way as the implementation in NLOpt, the tiny difference is just that the check in the __init__ function in the extension is also based on isdefined(Base, :get_extension) to ensure there are no cases when Optim.Optimizer is not defined).

This reintroduces MOI as a regular dependency on Julia < 1.9, but IMO this is fine since on Optim <= 1.9.2 MOI was a regular dependency already. On Julia >= 1.9, this PR actually reduces the number of dependencies since PackageExtensionsCompat is removed.

@pkofod
Copy link
Member

pkofod commented Mar 28, 2024

thanks David!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (7cc8328) to head (1961975).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   85.43%   85.46%   +0.02%     
==========================================
  Files          45       45              
  Lines        3276     3274       -2     
==========================================
- Hits         2799     2798       -1     
+ Misses        477      476       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkofod pkofod merged commit e4ef0a1 into JuliaNLSolvers:master Apr 2, 2024
9 checks passed
@devmotion devmotion deleted the dw/moi branch April 2, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eval in OptimMOIExt fails to precompile
2 participants