Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback stops for univariate optimization. #831

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Add callback stops for univariate optimization. #831

merged 2 commits into from
Jul 30, 2020

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Jul 10, 2020

Fixes #822

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #831 into master will increase coverage by 0.22%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   81.64%   81.86%   +0.22%     
==========================================
  Files          43       43              
  Lines        2446     2460      +14     
==========================================
+ Hits         1997     2014      +17     
+ Misses        449      446       -3     
Impacted Files Coverage Δ
src/univariate/solvers/brent.jl 95.65% <87.50%> (+5.32%) ⬆️
src/univariate/solvers/golden_section.jl 97.61% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0794f44...56fc17a. Read the comment docs.

@pkofod pkofod merged commit 84e4839 into master Jul 30, 2020
@pkofod pkofod deleted the unicallback branch July 30, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Univariate optimization does not stop when callback returns true
1 participant