Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-box in Fminbox. #862

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Fix out-of-box in Fminbox. #862

merged 2 commits into from
Sep 7, 2020

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Sep 7, 2020

Only evaluate the barrier term (to terminate linesearches etc) if out of box. #861

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #862 into master will increase coverage by 0.27%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   81.87%   82.14%   +0.27%     
==========================================
  Files          43       43              
  Lines        2764     2778      +14     
==========================================
+ Hits         2263     2282      +19     
+ Misses        501      496       -5     
Impacted Files Coverage Δ
src/multivariate/solvers/constrained/fminbox.jl 74.37% <80.76%> (+0.31%) ⬆️
src/utilities/perform_linesearch.jl 81.25% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab60867...65444a5. Read the comment docs.

@pkofod pkofod merged commit 580b464 into master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant