Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop being a ☠️ (fix #900, ldiv! and dot pirates Base). #916

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Apr 28, 2021

I just define our own that falls back to LinearAlgebra's.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #916 (e1f7dae) into master (adc5b27) will increase coverage by 0.10%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   83.59%   83.69%   +0.10%     
==========================================
  Files          43       43              
  Lines        3023     3024       +1     
==========================================
+ Hits         2527     2531       +4     
+ Misses        496      493       -3     
Impacted Files Coverage Δ
src/Optim.jl 100.00% <ø> (ø)
src/multivariate/precon.jl 70.00% <83.33%> (+14.44%) ⬆️
src/multivariate/solvers/constrained/samin.jl 78.06% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc5b27...e1f7dae. Read the comment docs.

@pkofod pkofod merged commit 2e7bcee into master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant