fix on 0.6 and drop 0.4 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @leethargo @blegat @yeesian @joaquimg @joehuchette |
|
So escaping behavior for ccall has changed somehow? Do you know the julia PR that discusses this change?
On Fri, Dec 9, 2016 at 10:44 PM -0500, "Miles Lubin" <notifications@github.com> wrote:
Merged #17.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Nothing specific to ccall. There was a longstanding bug with macro hygiene fixed in JuliaLang/julia#15850. |
|
Is this the reason JuMP is failing on nightly ? |
|
@mlubin How did you notice that this was needed on nightly ? It seems that nightly wasn't failing before the change of the pull request. Isn't it covered by the tests ? |
|
@blegat, it had been broken only very recently on Julia master. I tried it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.