Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MOI callbacks #120

Merged
merged 8 commits into from Oct 18, 2019
Merged

Implement MOI callbacks #120

merged 8 commits into from Oct 18, 2019

Conversation

odow
Copy link
Member

@odow odow commented Sep 25, 2019

Implements the MOI callbacks added jump-dev/MathOptInterface.jl#782

See also: jump-dev/Gurobi.jl#258

Requires:

  • a new tag of MOI and a minimum bound
  • Remove Manifest.toml

TODOs

  • tests currently failing with a segfault, sometimes proceeded (depending on small code changes) by
glp_delete_prob: operation not allowed
Error detected in file api/prob1.c at line 1582
error in running finalizer: GLPK.GLPKFatalError(msg="GLPK call failed. All GLPK objects you defined so far are now invalidated.")

Manifest.toml Outdated Show resolved Hide resolved
src/GLPK_checks.jl Outdated Show resolved Hide resolved
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #120 into master will increase coverage by 1.45%.
The diff coverage is 99.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   81.69%   83.14%   +1.45%     
==========================================
  Files           4        5       +1     
  Lines        1857     1952      +95     
==========================================
+ Hits         1517     1623     +106     
+ Misses        340      329      -11
Impacted Files Coverage Δ
src/GLPK.jl 80% <ø> (+1.4%) ⬆️
src/MOI_callbacks.jl 100% <100%> (ø)
src/MOI_wrapper.jl 89.69% <98.68%> (-0.45%) ⬇️
src/GLPK_checks.jl 70.32% <0%> (+2.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5183be...12b210d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 78.314% when pulling 37b423d on od/callbacks into 4ac8342 on master.

@coveralls
Copy link

coveralls commented Sep 25, 2019

Coverage Status

Coverage increased (+4.3%) to 81.048% when pulling 12b210d on od/callbacks into b5183be on master.

test/MOI_wrapper.jl Outdated Show resolved Hide resolved
src/MOI_callbacks.jl Outdated Show resolved Hide resolved
src/MOI_callbacks.jl Outdated Show resolved Hide resolved
@odow odow changed the title DNMY: implement MOI callbacks Implement MOI callbacks Oct 17, 2019
@odow
Copy link
Member Author

odow commented Oct 17, 2019

This is now passing tests and ready for another review.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@odow odow merged commit e90f5f0 into master Oct 18, 2019
@odow odow deleted the od/callbacks branch October 18, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants