Move isequal_canonical definition out of test, fix TODO. #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is seemingly only used by test/operator.jl, but I think the TODO is correct and moving this with other methods for AbstractJS is better.
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
==========================================
+ Coverage 88.87% 88.87% +<.01%
==========================================
Files 25 25
Lines 3695 3696 +1
==========================================
+ Hits 3284 3285 +1
Misses 411 411
Continue to review full report at Codecov.
|
mlubin
reviewed
Aug 27, 2018
src/JuMP.jl
Outdated
| # Check if two arrays of AbstractJuMPScalars are equal. Useful for testing. | ||
| function isequal_canonical(x::AbstractArray{<:JuMP.AbstractJuMPScalar}, | ||
| y::AbstractArray{<:JuMP.AbstractJuMPScalar}) | ||
| size(x) == size(y) && all(JuMP.isequal_canonical.(x, y)) |
mlubin
approved these changes
Aug 27, 2018
blegat
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is seemingly only used by test/operator.jl, but I think the TODO is
correct and moving this with other methods for AbstractJS is better.