Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MOI shortcut #1549

Closed
wants to merge 1 commit into from
Closed

Export MOI shortcut #1549

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 14, 2018

This PR exports MOI from JuMP so that users of JuMP do not have to copy paste

using MathOptInterface
const MOI = MathOptInterface

everywhere

This was suggested by @odow

@mlubin
Copy link
Member

mlubin commented Oct 14, 2018

This doesn't seem right. Having JuMP export a mysterious object named "MOI" doesn't help with readability of the code. Scipy doesn't export np as numpy. We should consider re-exporting the important enums from MOI like optimization sense and statuses.

@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #1549 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1549   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          27       27           
  Lines        3623     3623           
=======================================
  Hits         3242     3242           
  Misses        381      381
Impacted Files Coverage Δ
src/JuMP.jl 76.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a9e3c...eedd4cb. Read the comment docs.

@blegat blegat closed this Dec 12, 2018
@odow odow deleted the bl/moi branch December 30, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants