馃摑 Improve doc of optimize! #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 27 27
Lines 3626 3626
=======================================
Hits 3245 3245
Misses 381 381
Continue to review full report at Codecov.
|
mlubin
reviewed
Oct 25, 2018
mlubin
reviewed
Oct 25, 2018
src/optimizer_interface.jl
Outdated
| # ...fill model with variables, constraints and objectives... | ||
| # Solve the model with GLPK | ||
| JuMP.optimize!(model, with_optimizer(GLPK.Optimizer)) | ||
| # Solve the model with Clp |
There was a problem hiding this comment.
Why is the same model solved twice?
There was a problem hiding this comment.
You are right, it won't work, it will throw "An optimizer factory cannot both be provided in the Modelconstructor and at theoptimize call." at the second call
mlubin
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1559