Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for broadcast with unstable return type #1674

Merged
merged 3 commits into from Dec 13, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 12, 2018

Also added a small comment explaining how broadcasting is implemented

Closes #1673

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1674 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   67.91%   67.89%   -0.02%     
==========================================
  Files          30       30              
  Lines        3805     3806       +1     
==========================================
  Hits         2584     2584              
- Misses       1221     1222       +1
Impacted Files Coverage Δ
src/Containers/SparseAxisArray.jl 64.1% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af863fe...11762bc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1674 into master will increase coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   67.91%   68.48%   +0.57%     
==========================================
  Files          30       30              
  Lines        3805     3900      +95     
==========================================
+ Hits         2584     2671      +87     
- Misses       1221     1229       +8
Impacted Files Coverage Δ
src/Containers/SparseAxisArray.jl 64.1% <0%> (-0.84%) ⬇️
src/aff_expr.jl 72.13% <0%> (+0.57%) ⬆️
src/quad_expr.jl 71.73% <0%> (+1.15%) ⬆️
src/objective.jl 94.73% <0%> (+1.4%) ⬆️
src/variables.jl 86.26% <0%> (+4.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af863fe...d5414ab. Read the comment docs.

@blegat blegat merged commit 7afbd14 into master Dec 13, 2018
@odow odow deleted the bl/broadcastunstable branch December 30, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants