Fix broadcasting of DenseAxisArray with scalars #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
==========================================
+ Coverage 67.91% 69.46% +1.55%
==========================================
Files 30 31 +1
Lines 3805 4087 +282
==========================================
+ Hits 2584 2839 +255
- Misses 1221 1248 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
=========================================
+ Coverage 67.91% 70.01% +2.1%
=========================================
Files 30 31 +1
Lines 3805 4209 +404
=========================================
+ Hits 2584 2947 +363
- Misses 1221 1262 +41
Continue to review full report at Codecov.
|
jrevels
approved these changes
Dec 13, 2018
mlubin
reviewed
Dec 13, 2018
test/DenseAxisArray.jl
Outdated
| @test B[2] == 2.0 | ||
| @test B[3] == 3.0 | ||
| @test sprint(show, B) == """ | ||
| for B in [plus1.(A), A .+ 1, 1 .+ A] |
There was a problem hiding this comment.
- The printing part only needs to be tested once.
- IMO the following is more readable:
@test plus1.(A) == correct_answer
@test A .+ 1 == correct_answer
@test 1 .+ A == correct_answer
mlubin
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1455