Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message with invalid containers #1679

Merged
merged 1 commit into from Dec 13, 2018
Merged

Conversation

odow
Copy link
Member

@odow odow commented Dec 13, 2018

Closes #1672

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1679 into master will increase coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
+ Coverage   67.92%   68.02%   +0.09%     
==========================================
  Files          30       30              
  Lines        3810     3837      +27     
==========================================
+ Hits         2588     2610      +22     
- Misses       1222     1227       +5
Impacted Files Coverage Δ
src/macros.jl 83.49% <50%> (+0.19%) ⬆️
src/Containers/SparseAxisArray.jl 67.61% <0%> (+3.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afbd14...9122848. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1679 into master will increase coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
+ Coverage   67.92%   68.02%   +0.09%     
==========================================
  Files          30       30              
  Lines        3810     3837      +27     
==========================================
+ Hits         2588     2610      +22     
- Misses       1222     1227       +5
Impacted Files Coverage Δ
src/macros.jl 83.49% <50%> (+0.19%) ⬆️
src/Containers/SparseAxisArray.jl 67.61% <0%> (+3.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7afbd14...9122848. Read the comment docs.

@mlubin mlubin merged commit 1c4bfe1 into master Dec 13, 2018
@mlubin mlubin deleted the od/container_error branch December 13, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants