Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 quadterm -> quad_terms #1772

Merged
merged 3 commits into from Jan 14, 2019
Merged

🎨 quadterm -> quad_terms #1772

merged 3 commits into from Jan 14, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 13, 2019

In accordance to the JuMP style guide.

@blegat
Copy link
Member Author

blegat commented Jan 13, 2019

quadratic_terms or quad_term ? Now is the time for bikeshedding

@mlubin
Copy link
Member

mlubin commented Jan 13, 2019

We have QuadExpr so quad_terms seems fine.

@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #1772 into master will not change coverage.
The diff coverage is 73.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1772   +/-   ##
=======================================
  Coverage   69.57%   69.57%           
=======================================
  Files          30       30           
  Lines        3957     3957           
=======================================
  Hits         2753     2753           
  Misses       1204     1204
Impacted Files Coverage Δ
src/operators.jl 70% <100%> (ø) ⬆️
src/parse_expr.jl 67.85% <100%> (ø) ⬆️
src/print.jl 76.2% <66.66%> (ø) ⬆️
src/quad_expr.jl 70.27% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdb1e6...41bd798. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #1772 into master will not change coverage.
The diff coverage is 73.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1772   +/-   ##
=======================================
  Coverage   69.57%   69.57%           
=======================================
  Files          30       30           
  Lines        3957     3957           
=======================================
  Hits         2753     2753           
  Misses       1204     1204
Impacted Files Coverage Δ
src/operators.jl 70% <100%> (ø) ⬆️
src/parse_expr.jl 67.85% <100%> (ø) ⬆️
src/print.jl 76.2% <66.66%> (ø) ⬆️
src/quad_expr.jl 70.27% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdb1e6...be10496. Read the comment docs.

@blegat
Copy link
Member Author

blegat commented Jan 13, 2019

We have QuadExpr so quad_terms seems fine

Makes sense

src/quad_expr.jl Outdated Show resolved Hide resolved
@blegat blegat merged commit e72167e into master Jan 14, 2019
@odow odow deleted the bl/quad_terms branch January 15, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants