Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @SDconstraint with import #1795

Merged
merged 1 commit into from Jan 20, 2019
Merged

Fix @SDconstraint with import #1795

merged 1 commit into from Jan 20, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 19, 2019

Closes #1792

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #1795 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   69.53%   69.55%   +0.02%     
==========================================
  Files          30       30              
  Lines        3958     3958              
==========================================
+ Hits         2752     2753       +1     
+ Misses       1206     1205       -1
Impacted Files Coverage Δ
src/macros.jl 85.76% <100%> (ø) ⬆️
src/operators.jl 70.37% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69a3cc...7565f6e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited

Codecov Report

Merging #1795 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   69.53%   69.55%   +0.02%     
==========================================
  Files          30       30              
  Lines        3958     3958              
==========================================
+ Hits         2752     2753       +1     
+ Misses       1206     1205       -1
Impacted Files Coverage Δ
src/macros.jl 85.76% <100%> (ø) ⬆️
src/operators.jl 70.37% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69a3cc...7565f6e. Read the comment docs.

mlubin
mlubin approved these changes Jan 20, 2019
View reviewed changes
src/macros.jl
@@ -651,7 +651,7 @@ function parseSDconstraint(_error::Function, sense::Symbol, lhs, rhs)
_error("Invalid sense $sense in SDP constraint")
end
vectorized = false
parsecode, buildcall = parse_one_operator_constraint(_error, false, Val(:in), aff, :(PSDCone()))
parsecode, buildcall = parse_one_operator_constraint(_error, false, Val(:in), aff, :(JuMP.PSDCone()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this indicate an escaping issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the viewpoint of parse_one_perator_constraint, the last argument is the set given by the user so it should be in the user scope, not JuMP scope.

@blegat blegat merged commit 8b56fa1 into master Jan 20, 2019
@odow odow deleted the bl/importsdcon branch January 27, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blegat @mlubin