Add optional kwargs to optimize! for optimize_hook #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1987 +/- ##
==========================================
+ Coverage 88.86% 88.86% +<.01%
==========================================
Files 33 33
Lines 4282 4283 +1
==========================================
+ Hits 3805 3806 +1
Misses 477 477
Continue to review full report at Codecov.
|
odow
reviewed
Jun 17, 2019
odow
approved these changes
Jun 17, 2019
blegat
approved these changes
Jun 17, 2019
mlubin
reviewed
Jun 20, 2019
|
Done, should the error be thrown sooner to avoid side-effects if |
mlubin
reviewed
Jun 21, 2019
src/optimizer_interface.jl
Outdated
|
|
||
| Optimize the model. If `optimizer_factory` is not `nothing`, it first sets the | ||
| optimizer to a new one created using the optimizer factory. The factory can be | ||
| created using the [`with_optimizer`](@ref) function. If `optimizer_factory` is | ||
| `nothing` and no optimizer was set to `model` before calling this function, a | ||
| [`NoOptimizer`](@ref) error is thrown. | ||
|
|
||
| Keyword arguments `kwargs` are passed to the `optimize_hook`. An error is | ||
| thrown if `optimize_hook` is `nothing` and keyword arguments are provided |
There was a problem hiding this comment.
Nit: Please end the sentence with a period.
dourouc05
pushed a commit
to dourouc05/JuMP.jl
that referenced
this pull request
Jul 18, 2019
* Add optional kwargs to optimize! for optimize_hook * Add test for unexpected kwarg error * Add documentation on kwargs to optimize! * Formatting tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple change to pass along kwargs to the optimize_hook