Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MA API for BigFloat #25

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Implement MA API for BigFloat #25

merged 3 commits into from
Dec 13, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 12, 2019

@Peiffap
Copy link
Contributor

Peiffap commented Dec 12, 2019

Wouldn't it make more sense to add the code interacting with the MPFR library to Base, as is done with the equivalent code for BigInt?

@blegat
Copy link
Member Author

blegat commented Dec 12, 2019

Wouldn't it make more sense to add the code interacting with the MPFR library to Base, as is done with the equivalent code for BigInt?

Yes but as we want to support Julia v1.0, we can't rely on modifications on Base. Most of src/dispatch.jl are already workarounds for issues with Base that we'll need to keep until we drop Julia v1.0 for Julia v2.0 (i.e. for a very long time I guess :-P).

@blegat blegat merged commit 89694dc into master Dec 13, 2019
@blegat blegat deleted the bl/bigfloat branch December 23, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Would BigFloat see benefits similar to the BigInt speedup?
2 participants
@blegat @Peiffap