clean up

JuliaOptimalTransport · Jun 28, 2023 · b309a67 · b309a67
1 parent e757f79
commit b309a67
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 143 deletions.
diff --git a/src/quadratic_newton_symm.jl b/src/quadratic_newton_symm.jl
@@ -246,6 +246,10 @@ function solve!(solver::QuadraticOTSolver{<:SymmetricQuadraticOTNewtonAS})
     u_prev = similar(solver.cache.u)
     copy!(u_prev, solver.cache.u)
 
+    # active-set method only works for symmetric case with uniform weights.
+    # verify this is indeed the case
+    if !all(maximum(μ) .== μ) throw(ArgumentError("Active set method only works for uniform weights.")) end
+
     function check_convergence_dual(u, u_prev, atol, rtol)
         norm_diff = norm(u - u_prev)
         isconverged =
@@ -385,7 +389,6 @@ end
 
 
 # interface 
-
 function quadreg(μ, C, ε, alg::SymmetricQuadraticOTNewton; kwargs...)
     solver = build_solver(μ, C, ε, alg; kwargs...)
     solve!(solver)

diff --git a/test.jl b/test.jl